Home Original page

test: fix flaky test-fs-promises-file-handle-read by Trott · Pull Request #37371 · nodejs/node

@Trott added the flaky-test

Issues and PRs related to the tests with unstable failures on the CI.

label

Feb 14, 2021

@Trott Trott mentioned this pull request

Feb 14, 2021

RaisinTen

@Trott 

tmpdir.refresh() cannot be called multiple times reliably on Raspberry
Pi in CI because NFS might optimistically report a path as
removed before it actually is. At least, that's what I think is going
on. Anyway, tmpdir.refresh() is generally designed to be called once,
so let's just call it once.

PR-URL: nodejs#37371
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott deleted the fix-fs-test branch

February 17, 2021 03:36

targos pushed a commit that referenced this pull request

Feb 28, 2021 
tmpdir.refresh() cannot be called multiple times reliably on Raspberry
Pi in CI because NFS might optimistically report a path as
removed before it actually is. At least, that's what I think is going
on. Anyway, tmpdir.refresh() is generally designed to be called once,
so let's just call it once.

PR-URL: #37371
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>