[v12.x backport] module: improve support of data: URLs by aduh95 · Pull Request #37859

[v12.x backport] module: improve support of data: URLs by aduh95 · Pull Request #37859 · nodejs/node

nodejs / node Public

Notifications You must be signed in to change notification settings
Fork 35k
Star 116k

Merged

richardlau merged 2 commits intonodejs:v12.x-stagingfrom

aduh95:backport-data-url-v12.x

Mar 29, 2021

Merged

[v12.x backport] module: improve support of data: URLs#37859
richardlau merged 2 commits intonodejs:v12.x-stagingfrom
aduh95:backport-data-url-v12.x

Conversation

Copy link

Contributor

aduh95 commented
Mar 22, 2021

Backport of #37392.

I've also included #37394 which simply adds decodeURIComponent to primordials, but we could also leave it out and use it from the global object.

nodejs-github-bot added lib / src

Issues and PRs related to general changes in the lib or src directory.

needs-ci

PRs that need a full CI run.

v12.x labels

Mar 22, 2021

aduh95 requested a review from richardlau

March 22, 2021 11:24

Copy link

Collaborator

nodejs-github-bot commented
Mar 22, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36895/

Copy link

Member

richardlau commented
Mar 22, 2021

cc @nodejs/lts Any concerns with adding URI handling functions to primordials in 12.x?

Copy link

Collaborator

nodejs-github-bot commented
Mar 22, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36897/

richardlau approved these changes Mar 29, 2021

View reviewed changes

aduh95 added 2 commits

March 29, 2021 12:33

lib: add URI handling functions to primordials

2da24ac

PR-URL: nodejs#37394
Backport-PR-URL: nodejs#37859
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

module: improve support of data: URLs

7b0ed4b

Add support for loading modules using percent-encoded URLs.

PR-URL: nodejs#37392
Backport-PR-URL: nodejs#37859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

richardlau force-pushed the backport-data-url-v12.x branch from 3f6e97e to 7b0ed4b Compare