Home Original page

Remove the option of building against a shared cares by jbergstroem · Pull Request #38 · nodejs/node

@jbergstroem 

Bundled cares differs from upstream which will result
in a compilation error when trying to used a shared cares.

@cjihrig closed this

Dec 3, 2014

cjihrig pushed a commit that referenced this pull request

Dec 3, 2014 
Bundled cares differs from upstream which will result
in a compilation error when trying to used a shared cares.

Fixes: nodejs/node-v0.x-archive#8786
PR-URL: #38
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

rvagg pushed a commit that referenced this pull request

Dec 4, 2014 
Bundled cares differs from upstream which will result
in a compilation error when trying to used a shared cares.

Fixes: nodejs/node-v0.x-archive#8786
PR-URL: #38
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

rvagg pushed a commit that referenced this pull request

Dec 4, 2014 
Bundled cares differs from upstream which will result
in a compilation error when trying to used a shared cares.

Fixes: nodejs/node-v0.x-archive#8786
PR-URL: #38
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

rvagg pushed a commit that referenced this pull request

Dec 4, 2014 
Bundled cares differs from upstream which will result
in a compilation error when trying to used a shared cares.

Fixes: nodejs/node-v0.x-archive#8786
PR-URL: #38
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

rvagg pushed a commit that referenced this pull request

Dec 4, 2014 
Bundled cares differs from upstream which will result
in a compilation error when trying to used a shared cares.

Fixes: nodejs/node-v0.x-archive#8786
PR-URL: #38
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@rvagg rvagg mentioned this pull request

Jan 3, 2015

This was referenced

May 13, 2022

This was referenced

May 13, 2022

giancorderoortiz added a commit to giancorderoortiz/node_backports that referenced this pull request

Sep 6, 2024 
Original commit message:

    Merged: [parser] Using FunctionParsingScope for parsing class static blocks

    Class static blocks contain statements, don't inherit the
    ExpressionScope stack.

    (cherry picked from commit 3e037e195e508dea045f5626862412e8f64fc919)

    Bug: 341663589
    Change-Id: Ice9a710293b028e5d9fd30d5d85c4842f970b152
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5558360
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Reviewed-by: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/branch-heads/12.4@{nodejs#38}
    Cr-Branched-From: 309640da62fae0485c7e4f64829627c92d53b35d-refs/heads/12.4.254@{nodejs#1}
    Cr-Branched-From: 5dc24701432278556a9829d27c532f974643e6df-refs/heads/main@{#92862}

Refs: v8/v8@6e5e105