Home Original page

test: improve clarity of test-async-local-storage-enable-disable.js \… by PhakornKiong · Pull Request #38008 · nodejs/node

@nodejs-github-bot added async_hooks

Issues and PRs related to the async hooks subsystem.

needs-ci

PRs that need a full CI run.

test

Issues and PRs related to the tests.

labels

Mar 31, 2021

@PhakornKiong 

The last als.run() will reactivate the als,
hence the test should test for getting the object,
not undefined

@Flarna Flarna added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 1, 2021

Flarna pushed a commit that referenced this pull request

Apr 2, 2021 
The last als.run() will reactivate the als,
hence the test should test for getting the object,
not undefined

PR-URL: #38008
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Apr 4, 2021 
The last als.run() will reactivate the als,
hence the test should test for getting the object,
not undefined

PR-URL: #38008
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos pushed a commit that referenced this pull request

May 1, 2021 
The last als.run() will reactivate the als,
hence the test should test for getting the object,
not undefined

PR-URL: #38008
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>