fs: don't end fs promises on Isolate termination by santigimeno · Pull Request #42910

fs: don't end fs promises on Isolate termination by santigimeno · Pull Request #42910 · nodejs/node

added c++

Issues and PRs that require attention from people who are familiar with C++.

Issues and PRs related to the fs subsystem / file system.

needs-ci

PRs that need a full CI run.

labels

Apr 29, 2022

aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Apr 29, 2022

aduh95 removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 2, 2022

aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Jun 18, 2022

aduh95 added commit-queue

Add this label to land a pull request using GitHub Actions.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

Jun 18, 2022

This was referenced

Jun 19, 2022

targos pushed a commit that referenced this pull request

Jul 12, 2022

This is specially prevalent in the case of having in-progress FileHandle
operations in a worker thread while the Worker is exiting.

Fixes: #42829

PR-URL: #42910
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

targos pushed a commit that referenced this pull request

Jul 18, 2022

This is specially prevalent in the case of having in-progress FileHandle
operations in a worker thread while the Worker is exiting.

Fixes: #42829

PR-URL: #42910
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

targos pushed a commit that referenced this pull request

Jul 31, 2022

This is specially prevalent in the case of having in-progress FileHandle
operations in a worker thread while the Worker is exiting.

Fixes: #42829

PR-URL: #42910
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request

Oct 10, 2022

This is specially prevalent in the case of having in-progress FileHandle
operations in a worker thread while the Worker is exiting.

Fixes: nodejs/node#42829

PR-URL: nodejs/node#42910
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>