tools: refactor build-addons.js to ESM by F3n67u · Pull Request #43099

tools: refactor build-addons.js to ESM by F3n67u · Pull Request #43099 · nodejs/node

added build

Issues and PRs related to build files or the CI.

meta

Issues and PRs related to the general management of the project.

needs-ci

PRs that need a full CI run.

tools

Issues and PRs related to the tools directory.

windows

Issues and PRs related to the Windows platform.

labels

May 14, 2022

F3n67u marked this pull request as draft

May 14, 2022 14:20

F3n67u marked this pull request as ready for review

May 14, 2022 14:21

F3n67u changed the title ~~tools: refactor build-addons.js to esm module~~ tools: refactor build-addons.js to ESM

May 15, 2022

RaisinTen added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 16, 2022

This was referenced

May 17, 2022

aduh95 added request-ci

Add this label to start a Jenkins CI on a PR.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

May 20, 2022

This was referenced

May 23, 2022

bengl pushed a commit that referenced this pull request

May 30, 2022

PR-URL: #43099
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

bengl mentioned this pull request

May 31, 2022

juanarbol pushed a commit that referenced this pull request

May 31, 2022

PR-URL: #43099
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

F3n67u deleted the esm/build-addon branch

June 10, 2022 01:51

danielleadams pushed a commit that referenced this pull request

Jun 27, 2022

PR-URL: #43099
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request

Jul 12, 2022

PR-URL: #43099
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request

Jul 31, 2022

PR-URL: #43099
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request

Oct 10, 2022

PR-URL: nodejs/node#43099
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>