Home Original page

src: make SecureContext fields private by tniessen · Pull Request #43173 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

needs-ci

PRs that need a full CI run.

labels

May 22, 2022

@tniessen 

These fields should not be public. Only ctx_ is used outside of the
class itself, and should be accessed through the ctx() function
instead.

bnoordhuis

@tniessen tniessen added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

tls

Issues and PRs related to the tls subsystem.

labels

May 22, 2022

JungMinu

This was referenced

May 23, 2022

This was referenced

May 25, 2022

This was referenced

May 28, 2022

bengl pushed a commit that referenced this pull request

May 30, 2022 
These fields should not be public. Only ctx_ is used outside of the
class itself, and should be accessed through the ctx() function
instead.

PR-URL: #43173
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

@bengl bengl mentioned this pull request

May 31, 2022

danielleadams pushed a commit that referenced this pull request

Jun 27, 2022 
These fields should not be public. Only ctx_ is used outside of the
class itself, and should be accessed through the ctx() function
instead.

PR-URL: #43173
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

targos pushed a commit that referenced this pull request

Jul 12, 2022 
These fields should not be public. Only ctx_ is used outside of the
class itself, and should be accessed through the ctx() function
instead.

PR-URL: #43173
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

targos pushed a commit that referenced this pull request

Jul 31, 2022 
These fields should not be public. Only ctx_ is used outside of the
class itself, and should be accessed through the ctx() function
instead.

PR-URL: #43173
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

Aug 22, 2022

codebytere added a commit to electron/electron that referenced this pull request

Aug 24, 2022

codebytere added a commit to electron/electron that referenced this pull request

Aug 25, 2022

jkleinsc pushed a commit to electron/electron that referenced this pull request

Aug 29, 2022

guangwong pushed a commit to noslate-project/node that referenced this pull request

Oct 10, 2022 
These fields should not be public. Only ctx_ is used outside of the
class itself, and should be accessed through the ctx() function
instead.

PR-URL: nodejs/node#43173
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request

Feb 22, 2023