Home Original page

[v16.x backport] tools: update V8 gypfiles for 9.6 by RaisinTen · Pull Request #43247 · nodejs/node

@targos @RaisinTen 

PR-URL: nodejs#40488
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

tools

Issues and PRs related to the tools directory.

v16.x v8 engine

Issues and PRs related to the V8 dependency.

labels

May 30, 2022

@RaisinTen RaisinTen added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 30, 2022

@targos @RaisinTen 

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs#40488
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

gengjiawen

BethGriggs

juanarbol pushed a commit that referenced this pull request

May 31, 2022 
PR-URL: #40488
Backport-PR-URL: #43247
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

juanarbol pushed a commit that referenced this pull request

May 31, 2022 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: #40488
Backport-PR-URL: #43247
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

juanarbol pushed a commit that referenced this pull request

Jun 1, 2022 
PR-URL: #40488
Backport-PR-URL: #43247
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

juanarbol pushed a commit that referenced this pull request

Jun 1, 2022 
`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: #40488
Backport-PR-URL: #43247
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@RaisinTen RaisinTen deleted the backport-cross-compile-fix-to-v16.x branch

June 1, 2022 04:26