Home Original page

src: remove CopyBuffer by tniessen · Pull Request #43463 · nodejs/node

@tniessen 

CopyBuffer was used by the PBKDF2 implementation prior to the big
refactor, which removed those call sites.

@nodejs-github-bot nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

needs-ci

PRs that need a full CI run.

labels

Jun 17, 2022

@tniessen tniessen added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jun 18, 2022

VoltrexKeyva

This was referenced

Jun 19, 2022

RaisinTen

F3n67u pushed a commit to F3n67u/node that referenced this pull request

Jun 24, 2022 
CopyBuffer was used by the PBKDF2 implementation prior to the big
refactor, which removed those call sites.

PR-URL: nodejs#43463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

targos pushed a commit that referenced this pull request

Jul 12, 2022 
CopyBuffer was used by the PBKDF2 implementation prior to the big
refactor, which removed those call sites.

PR-URL: #43463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

targos pushed a commit that referenced this pull request

Jul 18, 2022 
CopyBuffer was used by the PBKDF2 implementation prior to the big
refactor, which removed those call sites.

PR-URL: #43463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

targos pushed a commit that referenced this pull request

Jul 31, 2022 
CopyBuffer was used by the PBKDF2 implementation prior to the big
refactor, which removed those call sites.

PR-URL: #43463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request

Oct 10, 2022 
CopyBuffer was used by the PBKDF2 implementation prior to the big
refactor, which removed those call sites.

PR-URL: nodejs/node#43463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>