src: refactor DH groups to delete crypto_groups.h by tniessen · Pull Request #43896

src: refactor DH groups to delete crypto_groups.h by tniessen · Pull Request #43896 · nodejs/node

Rewrite FindDiffieHellmanGroup() using OpenSSL helper functions to
obtain the required constants directly, instead of loading them from
our own crypto_groups.h and converting them to BIGNUMs.

This also removes the need for the struct modp_group, so we can delete
crypto_groups.h altogether.

added crypto

Issues and PRs related to the crypto subsystem.

lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Jul 18, 2022

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

Jul 18, 2022

tniessen removed the lib / src

Issues and PRs related to general changes in the lib or src directory.

label

Jul 19, 2022

This was referenced

Jul 20, 2022

This was referenced

Jul 22, 2022

tniessen added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jul 23, 2022

tniessen added a commit to tniessen/node that referenced this pull request

Jul 25, 2022

Instead of referring users to perl to find information about supported
MODP groups in crypto_groups.h, explicitly list the groups with their
respective strengths and with references to the defining RFC sections.

Refs: nodejs#43896

danielleadams pushed a commit that referenced this pull request

Jul 26, 2022

Rewrite FindDiffieHellmanGroup() using OpenSSL helper functions to
obtain the required constants directly, instead of loading them from
our own crypto_groups.h and converting them to BIGNUMs.

This also removes the need for the struct modp_group, so we can delete
crypto_groups.h altogether.

PR-URL: #43896
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

tniessen added a commit to tniessen/node that referenced this pull request

Jul 27, 2022

The referenced header file does not exist anymore.

Refs: nodejs#43896

ruyadorno pushed a commit that referenced this pull request

Aug 23, 2022

The referenced header file does not exist anymore.

Refs: #43896

PR-URL: #44012
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>

targos pushed a commit that referenced this pull request

Sep 5, 2022

Instead of referring users to perl to find information about supported
MODP groups in crypto_groups.h, explicitly list the groups with their
respective strengths and with references to the defining RFC sections.

Refs: #43896

PR-URL: #43986
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

targos pushed a commit that referenced this pull request

Sep 5, 2022

The referenced header file does not exist anymore.

Refs: #43896

PR-URL: #44012
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>

Fyko pushed a commit to Fyko/node that referenced this pull request

Sep 15, 2022

Rewrite FindDiffieHellmanGroup() using OpenSSL helper functions to
obtain the required constants directly, instead of loading them from
our own crypto_groups.h and converting them to BIGNUMs.

This also removes the need for the struct modp_group, so we can delete
crypto_groups.h altogether.

PR-URL: nodejs#43896
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Fyko pushed a commit to Fyko/node that referenced this pull request

Sep 15, 2022

Instead of referring users to perl to find information about supported
MODP groups in crypto_groups.h, explicitly list the groups with their
respective strengths and with references to the defining RFC sections.

Refs: nodejs#43896

PR-URL: nodejs#43986
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Fyko pushed a commit to Fyko/node that referenced this pull request

Sep 15, 2022

The referenced header file does not exist anymore.

Refs: nodejs#43896

PR-URL: nodejs#44012
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>

juanarbol pushed a commit that referenced this pull request

Oct 10, 2022

Instead of referring users to perl to find information about supported
MODP groups in crypto_groups.h, explicitly list the groups with their
respective strengths and with references to the defining RFC sections.

Refs: #43896

PR-URL: #43986
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

juanarbol pushed a commit that referenced this pull request

Oct 10, 2022

The referenced header file does not exist anymore.

Refs: #43896

PR-URL: #44012
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>

juanarbol pushed a commit that referenced this pull request

Oct 11, 2022

Instead of referring users to perl to find information about supported
MODP groups in crypto_groups.h, explicitly list the groups with their
respective strengths and with references to the defining RFC sections.

Refs: #43896

PR-URL: #43986
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

juanarbol pushed a commit that referenced this pull request

Oct 11, 2022

The referenced header file does not exist anymore.

Refs: #43896

PR-URL: #44012
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>