Home Original page

doc: remind backporter about v8_embedder_string by kvakil · Pull Request #43924 · nodejs/node

@nodejs-github-bot added the doc

Issues and PRs related to the documentations.

label

Jul 21, 2022

@kvakil 

There's already a reminder earlier in the instructions, but not in the
worked example, so it's easy to miss while skimming.

@kvakil kvakil changed the title docs: remind backporter about v8_embedder_string doc: remind backporter about v8_embedder_string

Jul 21, 2022

richardlau

BethGriggs

@F3n67u F3n67u added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jul 21, 2022

joyeecheung

RaisinTen

kvakil added a commit to kvakil/node that referenced this pull request

Jul 21, 2022 
Per the comments in nodejs#43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

kvakil added a commit to kvakil/node that referenced this pull request

Jul 21, 2022 
Per the comments in nodejs#43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

kvakil added a commit to kvakil/node that referenced this pull request

Jul 21, 2022 
Per the comments in nodejs#43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

I ran through both of these instructions on a clean Linux machine (I had
to fudge the patch SHA of course) and they seemed to work.

Refs: nodejs#43924

@aduh95 aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Jul 24, 2022

nodejs-github-bot pushed a commit that referenced this pull request

Jul 25, 2022 
Per the comments in #43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

I ran through both of these instructions on a clean Linux machine (I had
to fudge the patch SHA of course) and they seemed to work.

Refs: #43924

PR-URL: #43934
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

danielleadams pushed a commit that referenced this pull request

Jul 26, 2022 
There's already a reminder earlier in the instructions, but not in the
worked example, so it's easy to miss while skimming.

PR-URL: #43924
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

danielleadams pushed a commit that referenced this pull request

Jul 26, 2022 
Per the comments in #43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

I ran through both of these instructions on a clean Linux machine (I had
to fudge the patch SHA of course) and they seemed to work.

Refs: #43924

PR-URL: #43934
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

targos pushed a commit that referenced this pull request

Jul 31, 2022 
There's already a reminder earlier in the instructions, but not in the
worked example, so it's easy to miss while skimming.

PR-URL: #43924
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

targos pushed a commit that referenced this pull request

Jul 31, 2022 
Per the comments in #43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

I ran through both of these instructions on a clean Linux machine (I had
to fudge the patch SHA of course) and they seemed to work.

Refs: #43924

PR-URL: #43934
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

targos pushed a commit that referenced this pull request

Jul 31, 2022 
There's already a reminder earlier in the instructions, but not in the
worked example, so it's easy to miss while skimming.

PR-URL: #43924
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

targos pushed a commit that referenced this pull request

Jul 31, 2022 
Per the comments in #43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

I ran through both of these instructions on a clean Linux machine (I had
to fudge the patch SHA of course) and they seemed to work.

Refs: #43924

PR-URL: #43934
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

targos pushed a commit that referenced this pull request

Aug 1, 2022 
There's already a reminder earlier in the instructions, but not in the
worked example, so it's easy to miss while skimming.

PR-URL: #43924
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

targos pushed a commit that referenced this pull request

Aug 1, 2022 
Per the comments in #43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

I ran through both of these instructions on a clean Linux machine (I had
to fudge the patch SHA of course) and they seemed to work.

Refs: #43924

PR-URL: #43934
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

viceice-bot added a commit to renovate-reproductions/docker-node-versioning-issue that referenced this pull request

Aug 10, 2022

Fyko pushed a commit to Fyko/node that referenced this pull request

Sep 15, 2022 
There's already a reminder earlier in the instructions, but not in the
worked example, so it's easy to miss while skimming.

PR-URL: nodejs#43924
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

Fyko pushed a commit to Fyko/node that referenced this pull request

Sep 15, 2022 
Per the comments in nodejs#43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

I ran through both of these instructions on a clean Linux machine (I had
to fudge the patch SHA of course) and they seemed to work.

Refs: nodejs#43924

PR-URL: nodejs#43934
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request

Oct 10, 2022 
There's already a reminder earlier in the instructions, but not in the
worked example, so it's easy to miss while skimming.

PR-URL: nodejs/node#43924
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request

Oct 10, 2022 
Per the comments in #43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

I ran through both of these instructions on a clean Linux machine (I had
to fudge the patch SHA of course) and they seemed to work.

Refs: nodejs/node#43924

PR-URL: nodejs/node#43934
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>