Home Original page

src: remove usages of GetBackingStore in node-api by kvakil · Pull Request #44075 · nodejs/node

@kvakil 

This removes all usages of GetBackingStore in `node-api`. See the linked
issue for an explanation.

Refs: nodejs#32226
Refs: nodejs#43921

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

node-api

Issues and PRs related to the Node-API.

labels

Aug 1, 2022

RaisinTen

gengjiawen

@F3n67u F3n67u added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 1, 2022

mcollina

@kvakil kvakil removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 1, 2022

legendecas

addaleax

@kvakil kvakil added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 2, 2022

@kvakil kvakil added commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Aug 3, 2022

This was referenced

Aug 5, 2022

danielleadams pushed a commit that referenced this pull request

Aug 16, 2022 
This removes all usages of GetBackingStore in `node-api`. See the linked
issue for an explanation.

Refs: #32226
Refs: #43921
PR-URL: #44075
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

ruyadorno pushed a commit that referenced this pull request

Aug 23, 2022 
This removes all usages of GetBackingStore in `node-api`. See the linked
issue for an explanation.

Refs: #32226
Refs: #43921
PR-URL: #44075
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Fyko pushed a commit to Fyko/node that referenced this pull request

Sep 15, 2022 
This removes all usages of GetBackingStore in `node-api`. See the linked
issue for an explanation.

Refs: nodejs#32226
Refs: nodejs#43921
PR-URL: nodejs#44075
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>