Home Original page

doc,test: improvements and cleanup for assert.snapshot() by cjihrig · Pull Request #44429 · nodejs/node

@nodejs-github-bot added the needs-ci

PRs that need a full CI run.

label

Aug 28, 2022

@MoLow MoLow added the assert

Issues and PRs related to the assert subsystem.

label

Aug 28, 2022

tniessen

benjamingr

@MoLow MoLow mentioned this pull request

Aug 29, 2022

@cjihrig cjihrig added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

and removed needs-ci

PRs that need a full CI run.

labels

Aug 31, 2022

@cjihrig cjihrig added commit-queue

Add this label to land a pull request using GitHub Actions.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

Aug 31, 2022 
PR-URL: nodejs#44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This commit updates the assert.snapshot() fixtures to better
match the code style of the rest of the codebase.

PR-URL: nodejs#44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: nodejs#44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

This was referenced

Sep 2, 2022

RafaelGSS pushed a commit that referenced this pull request

Sep 5, 2022 
PR-URL: #44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Sep 5, 2022 
This commit updates the assert.snapshot() fixtures to better
match the code style of the rest of the codebase.

PR-URL: #44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Sep 5, 2022 
PR-URL: #44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Sep 6, 2022 
PR-URL: #44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Sep 6, 2022 
This commit updates the assert.snapshot() fixtures to better
match the code style of the rest of the codebase.

PR-URL: #44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Sep 6, 2022 
PR-URL: #44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Sep 7, 2022 
PR-URL: #44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Sep 7, 2022 
This commit updates the assert.snapshot() fixtures to better
match the code style of the rest of the codebase.

PR-URL: #44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Sep 7, 2022 
PR-URL: #44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

Fyko pushed a commit to Fyko/node that referenced this pull request

Sep 15, 2022 
PR-URL: nodejs#44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

Fyko pushed a commit to Fyko/node that referenced this pull request

Sep 15, 2022 
This commit updates the assert.snapshot() fixtures to better
match the code style of the rest of the codebase.

PR-URL: nodejs#44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

Fyko pushed a commit to Fyko/node that referenced this pull request

Sep 15, 2022 
PR-URL: nodejs#44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

@panva panva removed the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Nov 27, 2024