Home Original page

[v16.x backport] test runner additions by MoLow · Pull Request #44873 · nodejs/node

@MoLow changed the base branch from main to v16.x-staging

October 3, 2022 10:07

@nodejs-github-bot nodejs-github-bot added meta

Issues and PRs related to the general management of the project.

tools

Issues and PRs related to the tools directory.

labels

Oct 3, 2022

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44450
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44614
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

@MoLow MoLow marked this pull request as ready for review

October 3, 2022 10:16

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44450
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44614
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44450
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44614
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Oct 3, 2022 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44592
Backport-PR-URL: nodejs#44873
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

@MoLow MoLow mentioned this pull request

Nov 24, 2022

This was referenced

Nov 25, 2022

This was referenced

Nov 28, 2022

@p-b-o @MoLow 

This was confirmed flaky on those platforms:
- Windows x64
- Windows on Arm
- Linux
- Freebsd

Tests randomly fail because of bad order in messages expected, which
seems related to threads scheduling at execution.

PR-URL: nodejs#45049
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Dec 2, 2022

richardlau