Home Original page

build: restore Windows resource file by richardlau · Pull Request #45042 · nodejs/node

@richardlau 

Add back the Windows resource file to the build scripts that was
mistakenly removed by aa3a572.

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

needs-ci

PRs that need a full CI run.

labels

Oct 17, 2022

mhdawson

RafaelGSS

@richardlau richardlau added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 17, 2022

gengjiawen

VoltrexKeyva

RaisinTen

This was referenced

Oct 20, 2022

RafaelGSS pushed a commit that referenced this pull request

Nov 1, 2022 
Add back the Windows resource file to the build scripts that was
mistakenly removed by aa3a572.

PR-URL: #45042
Fixes: #45025
Refs: #43652
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Nov 10, 2022 
Add back the Windows resource file to the build scripts that was
mistakenly removed by aa3a572.

PR-URL: #45042
Fixes: #45025
Refs: #43652
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>