build,test: add proper support for IBM i by dmabupt · Pull Request #46739 · nodejs/node

@dmabupt

Python 3.9 on IBM i now properly returns "os400" for sys.platform
instead of claiming to be AIX as it did previously. While the IBM i PASE
environment is compatible with AIX, it is a subset and has numerous
differences which makes it beneficial to distinguish, however this means
that it now needs explicit support here.

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

cares

Issues and PRs related to the c-ares dependency or the cares_wrap binding.

dependencies

Pull requests that update a dependency file.

libuv

Issues and PRs related to the libuv dependency or the uv binding.

needs-ci

PRs that need a full CI run.

python

PRs and issues that require attention from people who are familiar with Python.

tools

Issues and PRs related to the tools directory.

v8 engine

Issues and PRs related to the V8 dependency.

labels

Feb 20, 2023

@richardlau richardlau added ibm i

Issues and PRs related to the IBM i platform.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Feb 20, 2023

richardlau

@richardlau richardlau added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Feb 21, 2023

targos pushed a commit that referenced this pull request

Mar 13, 2023
Python 3.9 on IBM i now properly returns "os400" for sys.platform
instead of claiming to be AIX as it did previously. While the IBM i PASE
environment is compatible with AIX, it is a subset and has numerous
differences which makes it beneficial to distinguish, however this means
that it now needs explicit support here.

PR-URL: #46739
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

danielleadams pushed a commit that referenced this pull request

Apr 11, 2023
Python 3.9 on IBM i now properly returns "os400" for sys.platform
instead of claiming to be AIX as it did previously. While the IBM i PASE
environment is compatible with AIX, it is a subset and has numerous
differences which makes it beneficial to distinguish, however this means
that it now needs explicit support here.

PR-URL: #46739
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

codebytere added a commit to electron/electron that referenced this pull request

Apr 14, 2023

codebytere added a commit to electron/electron that referenced this pull request

Apr 17, 2023

codebytere added a commit to electron/electron that referenced this pull request

Apr 18, 2023
* chore: bump node in DEPS to v18.16.0

* build,test: add proper support for IBM i

nodejs/node#46739

* lib: enforce use of trailing commas

nodejs/node#46881

* src: add initial support for single executable applications

nodejs/node#45038

* lib: do not crash using workers with disabled shared array buffers

nodejs/node#41023

* src: remove shadowed variable in OptionsParser::Parse

nodejs/node#46672

* src: allow embedder control of code generation policy

nodejs/node#46368

* src: allow optional Isolate termination in node::Stop()

nodejs/node#46583

* lib: fix BroadcastChannel initialization location

nodejs/node#46864

* chore: fixup patch indices

* chore: sync filenames.json

* fix: add simdutf dep to src/inspector BUILD.gn

- nodejs/node#46471
- nodejs/node#46472

* deps: replace url parser with Ada

nodejs/node#46410

* tls: support automatic DHE

nodejs/node#46978

* fixup! src: add initial support for single executable applications

* http: unify header treatment

nodejs/node#46528

* fix: libc++ buffer overflow in string_view ctor

nodejs/node#46410

* test: include strace openat test

nodejs/node#46150

* fixup! fixup! src: add initial support for single executable applications

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

This was referenced

May 18, 2023

nodejs-github-bot pushed a commit that referenced this pull request

Sep 29, 2023
When built with Python 3.9 on IBM i, `process.platform` will return
`os400` instead of `aix`. In preparation for this, make `common.isAIX`
only return true for AIX and update the tests to add checks for
`common.isIBMi` where they were missing.

PR-URL: #48056
Refs: #46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request

Sep 29, 2023
Python 3.9 on IBM i returns "os400" for `sys.platform`.

PR-URL: #48056
Refs: #46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

GeoffreyBooth pushed a commit to GeoffreyBooth/node that referenced this pull request

Oct 1, 2023
When built with Python 3.9 on IBM i, `process.platform` will return
`os400` instead of `aix`. In preparation for this, make `common.isAIX`
only return true for AIX and update the tests to add checks for
`common.isIBMi` where they were missing.

PR-URL: nodejs#48056
Refs: nodejs#46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

GeoffreyBooth pushed a commit to GeoffreyBooth/node that referenced this pull request

Oct 1, 2023
Python 3.9 on IBM i returns "os400" for `sys.platform`.

PR-URL: nodejs#48056
Refs: nodejs#46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Oct 28, 2023
When built with Python 3.9 on IBM i, `process.platform` will return
`os400` instead of `aix`. In preparation for this, make `common.isAIX`
only return true for AIX and update the tests to add checks for
`common.isIBMi` where they were missing.

PR-URL: #48056
Refs: #46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Oct 28, 2023
Python 3.9 on IBM i returns "os400" for `sys.platform`.

PR-URL: #48056
Refs: #46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023
When built with Python 3.9 on IBM i, `process.platform` will return
`os400` instead of `aix`. In preparation for this, make `common.isAIX`
only return true for AIX and update the tests to add checks for
`common.isIBMi` where they were missing.

PR-URL: nodejs#48056
Refs: nodejs#46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023
Python 3.9 on IBM i returns "os400" for `sys.platform`.

PR-URL: nodejs#48056
Refs: nodejs#46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Nov 11, 2023
When built with Python 3.9 on IBM i, `process.platform` will return
`os400` instead of `aix`. In preparation for this, make `common.isAIX`
only return true for AIX and update the tests to add checks for
`common.isIBMi` where they were missing.

PR-URL: #48056
Refs: #46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Nov 11, 2023
Python 3.9 on IBM i returns "os400" for `sys.platform`.

PR-URL: #48056
Refs: #46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

debadree25 pushed a commit to debadree25/node that referenced this pull request

Apr 15, 2024
When built with Python 3.9 on IBM i, `process.platform` will return
`os400` instead of `aix`. In preparation for this, make `common.isAIX`
only return true for AIX and update the tests to add checks for
`common.isIBMi` where they were missing.

PR-URL: nodejs#48056
Refs: nodejs#46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

debadree25 pushed a commit to debadree25/node that referenced this pull request

Apr 15, 2024
Python 3.9 on IBM i returns "os400" for `sys.platform`.

PR-URL: nodejs#48056
Refs: nodejs#46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024
When built with Python 3.9 on IBM i, `process.platform` will return
`os400` instead of `aix`. In preparation for this, make `common.isAIX`
only return true for AIX and update the tests to add checks for
`common.isIBMi` where they were missing.

PR-URL: nodejs/node#48056
Refs: nodejs/node#46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024
Python 3.9 on IBM i returns "os400" for `sys.platform`.

PR-URL: nodejs/node#48056
Refs: nodejs/node#46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024
When built with Python 3.9 on IBM i, `process.platform` will return
`os400` instead of `aix`. In preparation for this, make `common.isAIX`
only return true for AIX and update the tests to add checks for
`common.isIBMi` where they were missing.

PR-URL: nodejs/node#48056
Refs: nodejs/node#46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024
Python 3.9 on IBM i returns "os400" for `sys.platform`.

PR-URL: nodejs/node#48056
Refs: nodejs/node#46739
Refs: nodejs/build#3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>