Home Original page

src: fix duplication of externalized builtin code by kvakil · Pull Request #47079 · nodejs/node

@kvakil 

The `else` here was missing, causing us to append the file to its
existing `source` already in the map.

Refs: nodejs#45942

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

Mar 14, 2023

addaleax

@kvakil kvakil added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 15, 2023

@kvakil kvakil added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Mar 17, 2023

targos pushed a commit that referenced this pull request

Mar 18, 2023 
The `else` here was missing, causing us to append the file to its
existing `source` already in the map.

Refs: #45942
PR-URL: #47079
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

This was referenced

Mar 19, 2023

targos pushed a commit that referenced this pull request

Nov 10, 2023 
The `else` here was missing, causing us to append the file to its
existing `source` already in the map.

Refs: #45942
PR-URL: #47079
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024 
The `else` here was missing, causing us to append the file to its
existing `source` already in the map.

Refs: nodejs/node#45942
PR-URL: nodejs/node#47079
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024 
The `else` here was missing, causing us to append the file to its
existing `source` already in the map.

Refs: nodejs/node#45942
PR-URL: nodejs/node#47079
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>