- Explicitly specify the encoding when opening files.
- Use f-strings to format strings.
- Use `isinstance()` for type checks instead of `type()`.
- Use the `with` keyword for resource-allocating operations.
- Avoid using multiple statements in a single line.
- Remove unnecessary `else` clauses after `return`.
- Iterate with the `items()` method of dictionaries when both the key
and value are used.
- Remove unnecessary parentheses.
- Rename unused unpacked variables to `_`, `_1`, etc etc.
- Rename the `list` variable to avoid conflict with the global
`list()` function.
- Remove unused `path` parameter of the `icu_download()` function.
- Use the `pathlib` library for paths instead of `os.path`.

VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request

VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request

VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request

VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request

VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request

VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request

VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request

VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request

VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request

nodejs-github-bot pushed a commit that referenced this pull request

Use Python's `pathlib` library for paths and related operations
instead of `os.path`.

Refs: #47323 (comment) #47323 (comment)
PR-URL: #47581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Christian Clauss <cclauss@me.com>

targos pushed a commit that referenced this pull request

Use Python's `pathlib` library for paths and related operations
instead of `os.path`.

Refs: #47323 (comment) #47323 (comment)
PR-URL: #47581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Christian Clauss <cclauss@me.com>

targos pushed a commit that referenced this pull request

Use Python's `pathlib` library for paths and related operations
instead of `os.path`.

Refs: #47323 (comment) #47323 (comment)
PR-URL: #47581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Christian Clauss <cclauss@me.com>

danielleadams pushed a commit that referenced this pull request

Use Python's `pathlib` library for paths and related operations
instead of `os.path`.

Refs: #47323 (comment) #47323 (comment)
PR-URL: #47581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Christian Clauss <cclauss@me.com>

MoLow pushed a commit to MoLow/node that referenced this pull request

srl295 added the i18n-api

label