Home Original page

src: use correct variable in node_builtins.cc by targos · Pull Request #47343 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

Mar 31, 2023

legendecas

joyeecheung

@targos targos marked this pull request as draft

April 1, 2023 07:00

@targos

@targos targos marked this pull request as ready for review

April 4, 2023 11:33

@targos targos changed the title src: remove unused variable in node_builtins.cc src: use correct variable in node_builtins.cc

Apr 4, 2023

legendecas

joyeecheung

@targos targos added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Apr 11, 2023

targos added a commit that referenced this pull request

May 2, 2023 
PR-URL: #47343
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

danielleadams pushed a commit that referenced this pull request

Jul 6, 2023 
PR-URL: #47343
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MoLow pushed a commit to MoLow/node that referenced this pull request

Jul 6, 2023 
PR-URL: nodejs#47343
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>