Home Original page

src: get binding data store directly from the realm by joyeecheung · Pull Request #47437 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

Apr 5, 2023

legendecas

This was referenced

Apr 25, 2023

@joyeecheung 

We now store the binding data store in the realm and invoke
`Realm::AddBindingData` to add the binding data, so there is no
need to get a reference to the binding data store from the context
now, we can just get the reference from the realm.

@legendecas legendecas added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 28, 2023

This was referenced

Apr 29, 2023

This was referenced

May 2, 2023

joyeecheung added a commit that referenced this pull request

May 4, 2023 
We now store the binding data store in the realm and invoke
`Realm::AddBindingData` to add the binding data, so there is no
need to get a reference to the binding data store from the context
now, we can just get the reference from the realm.

PR-URL: #47437
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

May 12, 2023 
We now store the binding data store in the realm and invoke
`Realm::AddBindingData` to add the binding data, so there is no
need to get a reference to the binding data store from the context
now, we can just get the reference from the realm.

PR-URL: #47437
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>