Home Original page

doc: add missing setEncoding call in ESM example by addaleax · Pull Request #47558 · nodejs/node

@addaleax 

Adding `setEncoding()` ensures that the example handles characters
split across chunk boundaries well.

@addaleax added doc

Issues and PRs related to the documentations.

esm

Issues and PRs related to the ECMAScript Modules implementation.

labels

Apr 14, 2023

@aduh95 aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Apr 14, 2023

@MoLow MoLow added the fast-track

PRs that do not need to wait for 72 hours to land.

label

Apr 14, 2023

tniessen

HarshithaKP

RafaelGSS

targos pushed a commit that referenced this pull request

May 2, 2023 
Adding `setEncoding()` ensures that the example handles characters
split across chunk boundaries well.

PR-URL: #47558
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

danielleadams pushed a commit that referenced this pull request

Jul 6, 2023 
Adding `setEncoding()` ensures that the example handles characters
split across chunk boundaries well.

PR-URL: #47558
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

MoLow pushed a commit to MoLow/node that referenced this pull request

Jul 6, 2023 
Adding `setEncoding()` ensures that the example handles characters
split across chunk boundaries well.

PR-URL: nodejs#47558
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>