Home Original page

sea: add option to disable the experimental SEA warning by RaisinTen · Pull Request #47588 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

single-executable

Issues and PRs related to single-executable applications

labels

Apr 17, 2023

addaleax

mhdawson

mhdawson

@RaisinTen RaisinTen added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

labels

Apr 18, 2023

joyeecheung

bnb

bnb approved these changes Apr 24, 2023

RaisinTen added a commit to RaisinTen/node that referenced this pull request

Apr 25, 2023

@RaisinTen RaisinTen removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 25, 2023

joyeecheung

RaisinTen added a commit to RaisinTen/node that referenced this pull request

Apr 26, 2023

RaisinTen added a commit to RaisinTen/node that referenced this pull request

Apr 26, 2023

RaisinTen added a commit to RaisinTen/node that referenced this pull request

Apr 26, 2023 
Node.js uses UTF-8 for almost all things as the default internally, and
this method should not be an exception

Refs: nodejs#47588 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
It makes more sense to use a Maybe here because that conveys the meaning
that it is unsafe to call into V8 if an exception is pending. Using
std::optional does not make that obvious.

Refs: nodejs#47588 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
These became flaky on osx11-x64 Jenkins CI the moment we started running
multiple single-executable tests in parallel, so it makes sense to run
these sequentially for now.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

@RaisinTen 

Signed-off-by: Darshan Sen <raisinten@gmail.com>

@RaisinTen

@RaisinTen

@RaisinTen 

Signed-off-by: Darshan Sen <raisinten@gmail.com>
Signed-off-by: Darshan Sen <raisinten@gmail.com>

joyeecheung

@RaisinTen RaisinTen deleted the sea-add-option-to-disable-experimental-sea-warning branch

May 4, 2023 15:28

targos pushed a commit that referenced this pull request

May 12, 2023 
Refs: nodejs/single-executable#60
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #47588
Fixes: #47741
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@targos targos added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

May 15, 2023

targos added a commit that referenced this pull request

May 15, 2023 
Notable changes:

doc:
  * add ovflowd to collaborators (Claudio Wunder) #47844
http:
  * (SEMVER-MINOR) prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732
sea:
  * (SEMVER-MINOR) add option to disable the experimental SEA warning (Darshan Sen) #47588
test_runner:
  * (SEMVER-MINOR) add `skip`, `todo`, and `only` shorthands to `test` (Chemi Atlow) #47909
url:
  * (SEMVER-MINOR) add value argument to `URLSearchParams` `has` and `delete` methods (Sankalp Shubham) #47885

PR-URL: #48020

targos added a commit that referenced this pull request

May 16, 2023 
Notable changes:

doc:
  * add ovflowd to collaborators (Claudio Wunder) #47844
http:
  * (SEMVER-MINOR) prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732
sea:
  * (SEMVER-MINOR) add option to disable the experimental SEA warning (Darshan Sen) #47588
test_runner:
  * (SEMVER-MINOR) add `skip`, `todo`, and `only` shorthands to `test` (Chemi Atlow) #47909
url:
  * (SEMVER-MINOR) add value argument to `URLSearchParams` `has` and `delete` methods (Sankalp Shubham) #47885

PR-URL: #48020