Enable Node.js to run with Microsoft's ChakraCore engine by kunalspathak · Pull Request #4765 · nodejs/node
added 2 commits
January 12, 2016 12:22ChakraShim implements essential V8 APIs needed by Node.js on top of the Chakra runtime hosting API (JSRT). This enables Node.js and other native addon modules written for V8 to build and run with the Chakra JavaScript engine.
Source code of [chakracore](https://github.com/Microsoft/ChakraCore.git) that lights up Node.js for Chakra. Building Node.js with Chakra produces chakracore.dll along with other binaries that is needed by node.exe to function.
Fishrock123
added
vm
labels
Jan 19, 2016
jasnell
added
semver-major
labels
Jan 19, 2016This was referenced
Feb 12, 2016MylesBorins pushed a commit that referenced this pull request
Feb 17, 2016Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced
Feb 17, 2016MylesBorins pushed a commit that referenced this pull request
Feb 18, 2016Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request
Mar 2, 2016Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta pushed a commit to scovetta/node that referenced this pull request
Apr 2, 2016Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (nodejs#4765) for obvious reason. PR-URL: nodejs#4769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
kunalspathak added a commit to kunalspathak/node-gyp that referenced this pull request
Dec 12, 2016Microsoft's chakracore engine is dependent on Windows SDK, and build tools should know the version installed on user machine. This change adds those dependencies in node-gyp tools. Below is the summary: * Configure msvs_windows_target_platform_version to use the right Windows SDK. * Configure msvs_use_library_dependency_inputs to export symbols correctly (otherwise functions not used by node.exe but might be needed by native addon modules could be optimized away by linker). These changes were originally made in nodejs/node#4765, but as @shigeki mentioned, it was more sensible to send these changes as PR to node-gyp repo.
kunalspathak added a commit to kunalspathak/node-gyp that referenced this pull request
Jan 19, 2017Microsoft's chakracore engine is dependent on Windows SDK, and build tools should know the version installed on user machine. This change adds those dependencies in node-gyp tools. Below is the summary: * Configure msvs_windows_target_platform_version to use the right Windows SDK. * Configure msvs_use_library_dependency_inputs to export symbols correctly (otherwise functions not used by node.exe but might be needed by native addon modules could be optimized away by linker). These changes were originally made in nodejs/node#4765, but as @shigeki mentioned, it was more sensible to send these changes as PR to node-gyp repo.
bnoordhuis pushed a commit to nodejs/node-gyp that referenced this pull request
Feb 15, 2017Microsoft's chakracore engine is dependent on Windows SDK, and build tools should know the version installed on user machine. This change adds those dependencies in node-gyp tools. Below is the summary: * Configure msvs_windows_target_platform_version to use the right Windows SDK. * Configure msvs_use_library_dependency_inputs to export symbols correctly (otherwise functions not used by node.exe but might be needed by native addon modules could be optimized away by linker). These changes were originally made in nodejs/node#4765, but as @shigeki mentioned, it was more sensible to send these changes as PR to node-gyp repo. PR-URL: #873 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters