Home Original page

test_runner: remove no-op validation by cjihrig · Pull Request #47687 · nodejs/node

@cjihrig 

The code already checks if testNamePatterns is an
array, and converts it to an array if it is not.

benjamingr

debadree25

@debadree25 debadree25 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Apr 23, 2023

deokjinkim

@MoLow MoLow added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Apr 24, 2023

yjl9903 pushed a commit to yjl9903/node that referenced this pull request

Apr 28, 2023 
The code already checks if testNamePatterns is an
array, and converts it to an array if it is not.

PR-URL: nodejs#47687
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

yjl9903 pushed a commit to yjl9903/node that referenced this pull request

Apr 28, 2023 
The code already checks if testNamePatterns is an
array, and converts it to an array if it is not.

PR-URL: nodejs#47687
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

yjl9903 pushed a commit to yjl9903/node that referenced this pull request

Apr 29, 2023 
The code already checks if testNamePatterns is an
array, and converts it to an array if it is not.

PR-URL: nodejs#47687
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

targos pushed a commit that referenced this pull request

May 2, 2023 
The code already checks if testNamePatterns is an
array, and converts it to an array if it is not.

PR-URL: #47687
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

danielleadams pushed a commit that referenced this pull request

Jul 6, 2023 
The code already checks if testNamePatterns is an
array, and converts it to an array if it is not.

PR-URL: #47687
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

MoLow pushed a commit to MoLow/node that referenced this pull request

Jul 6, 2023 
The code already checks if testNamePatterns is an
array, and converts it to an array if it is not.

PR-URL: nodejs#47687
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>