Home Original page

test: migrate a pseudo_tty test to use assertSnapshot by MoLow · Pull Request #47803 · nodejs/node

@MoLow marked this pull request as draft

May 1, 2023 18:01

@MoLow MoLow mentioned this pull request

May 1, 2023

@MoLow MoLow marked this pull request as ready for review

May 1, 2023 20:06

ljharb

GeoffreyBooth

@MoLow MoLow changed the title test: migrate pseudo_tty tests to use assertSnapshot test: migrate a pseudo_tty test to use assertSnapshot

May 2, 2023

@MoLow

@MoLow MoLow added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

May 2, 2023

benjamingr

@MoLow

benjamingr

@MoLow MoLow deleted the migrate-psuedo-tty branch

May 4, 2023 08:57

targos pushed a commit that referenced this pull request

May 12, 2023 
PR-URL: #47803
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

danielleadams pushed a commit that referenced this pull request

Jul 6, 2023 
PR-URL: #47803
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Jul 6, 2023 
PR-URL: nodejs#47803
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>