Home Original page

test_runner: omit inaccessible files from coverage by cjihrig · Pull Request #47850 · nodejs/node

@cjihrig 

If V8 generates code coverage for a file that is later
inaccessible to the test runner, then omit that file from the
coverage report.

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

labels

May 4, 2023

@MoLow MoLow added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 5, 2023

BethGriggs

@cjihrig cjihrig added commit-queue

Add this label to land a pull request using GitHub Actions.

and removed needs-ci

PRs that need a full CI run.

labels

May 10, 2023

@cjihrig cjihrig deleted the coverage-deleted branch

May 10, 2023 14:16

targos pushed a commit that referenced this pull request

May 12, 2023 
If V8 generates code coverage for a file that is later
inaccessible to the test runner, then omit that file from the
coverage report.

PR-URL: #47850
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>

danielleadams pushed a commit that referenced this pull request

Jul 6, 2023 
If V8 generates code coverage for a file that is later
inaccessible to the test runner, then omit that file from the
coverage report.

PR-URL: #47850
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>

MoLow pushed a commit to MoLow/node that referenced this pull request

Jul 6, 2023 
If V8 generates code coverage for a file that is later
inaccessible to the test runner, then omit that file from the
coverage report.

PR-URL: nodejs#47850
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>