Home Original page

benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` by deokjinkim · Pull Request #48002 · nodejs/node

@nodejs-github-bot added benchmark

Issues and PRs related to the benchmark subsystem.

cluster

Issues and PRs related to the cluster subsystem.

http

Issues or PRs related to the http subsystem.

needs-ci

PRs that need a full CI run.

test

Issues and PRs related to the tests.

labels

May 14, 2023

tniessen

@deokjinkim 

`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: nodejs#47981

@deokjinkim deokjinkim changed the title benchmark,test: use cluster.isPrimary instead of cluster.isMaster benchmark: use cluster.isPrimary instead of cluster.isMaster

May 14, 2023

tniessen

@deokjinkim deokjinkim added request-ci

Add this label to start a Jenkins CI on a PR.

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed http

Issues or PRs related to the http subsystem.

test

Issues and PRs related to the tests.

labels

May 15, 2023

targos pushed a commit that referenced this pull request

May 30, 2023 
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: #47981
PR-URL: #48002
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

danielleadams pushed a commit that referenced this pull request

Jul 6, 2023 
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: #47981
PR-URL: #48002
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MoLow pushed a commit to MoLow/node that referenced this pull request

Jul 6, 2023 
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: nodejs#47981
PR-URL: nodejs#48002
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>