lib: support `FORCE_COLOR` for non TTY streams by MoLow · Pull Request #48034

lib: support `FORCE_COLOR` for non TTY streams by MoLow · Pull Request #48034 · nodejs/node

added lib / src

Issues and PRs related to general changes in the lib or src directory.

needs-ci

PRs that need a full CI run.

labels

May 16, 2023

MoLow added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

May 17, 2023

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow added the commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

label

May 17, 2023

This was referenced

May 23, 2023

targos pushed a commit that referenced this pull request

May 30, 2023

PR-URL: #48034
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Jul 6, 2023

PR-URL: nodejs#48034
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow mentioned this pull request

Jul 6, 2023

MoLow added a commit to MoLow/node that referenced this pull request

Jul 9, 2023

PR-URL: nodejs#48034
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request

Jul 9, 2023

PR-URL: nodejs#48034
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow mentioned this pull request

Jul 9, 2023

MoLow added a commit to MoLow/node that referenced this pull request

Jul 9, 2023

PR-URL: nodejs#48034
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

danielleadams pushed a commit that referenced this pull request

Jul 12, 2023

PR-URL: #48034
Backport-PR-URL: #48684
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow mentioned this pull request

Jan 26, 2024

dgozman added a commit to microsoft/playwright that referenced this pull request

Mar 25, 2024

This was historically done to make `console.log()` have colors. However,
this makes any other code that checks `process.stdout.isTTY` incorrectly
assume real TTY support.

Node18 and Node20 now respect `FORCE_COLOR=1` in console, so our default
behavior of forcing colors in the worker process just works out of the
box. See nodejs/node#48034.