Home Original page

test: refactor test-gc-http-client-timeout by lpinca · Pull Request #48292 · nodejs/node

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

test

Issues and PRs related to the tests.

labels

Jun 2, 2023

santigimeno

@lpinca 

Due to server response delay, all possible requests are created anyway.
Instead of doing `36 * os.availableParallelism()` requests, use a fixed
number.

Refs: nodejs#48078 (comment)

@anonrig anonrig added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jun 3, 2023

LiviaMedeiros

This was referenced

Jun 4, 2023

@lpinca lpinca added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Jun 6, 2023

@lpinca lpinca deleted the refactor/test-gc-http-client-timeout branch

June 6, 2023 16:13

This was referenced

Jun 10, 2023

RafaelGSS pushed a commit that referenced this pull request

Jul 3, 2023 
Due to server response delay, all possible requests are created anyway.
Instead of doing `36 * os.availableParallelism()` requests, use a fixed
number.

Refs: #48078 (comment)
PR-URL: #48292
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023 
Due to server response delay, all possible requests are created anyway.
Instead of doing `36 * os.availableParallelism()` requests, use a fixed
number.

Refs: nodejs#48078 (comment)
PR-URL: nodejs#48292
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023 
Due to server response delay, all possible requests are created anyway.
Instead of doing `36 * os.availableParallelism()` requests, use a fixed
number.

Refs: nodejs#48078 (comment)
PR-URL: nodejs#48292
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

ruyadorno pushed a commit that referenced this pull request

Aug 29, 2023 
Due to server response delay, all possible requests are created anyway.
Instead of doing `36 * os.availableParallelism()` requests, use a fixed
number.

Refs: #48078 (comment)
PR-URL: #48292
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>