Home Original page

bootstrap: hide experimental web globals with flag kNoBrowserGlobals by legendecas · Pull Request #48545 · nodejs/node

@legendecas 

Do not install experimental web globals when the environment is
initialized with embedder flag
`node::EnvironmentFlags::kNoBrowserGlobals`.

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

process

Issues and PRs related to the process subsystem.

labels

Jun 25, 2023

This was referenced

Jun 27, 2023

@legendecas legendecas added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Jul 5, 2023

juanarbol pushed a commit that referenced this pull request

Jul 13, 2023 
Do not install experimental web globals when the environment is
initialized with embedder flag
`node::EnvironmentFlags::kNoBrowserGlobals`.

PR-URL: #48545
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023 
Do not install experimental web globals when the environment is
initialized with embedder flag
`node::EnvironmentFlags::kNoBrowserGlobals`.

PR-URL: nodejs#48545
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023 
Do not install experimental web globals when the environment is
initialized with embedder flag
`node::EnvironmentFlags::kNoBrowserGlobals`.

PR-URL: nodejs#48545
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>