Home Original page

util: Use `primordials.ArrayPrototypeIndexOf` instead of mutable method by DaisyDogs07 · Pull Request #48586 · nodejs/node

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

util

Issues and PRs related to the built-in util module.

labels

Jun 28, 2023

@DaisyDogs07 DaisyDogs07 changed the title Use primordial ArrayPrototypeIndexOf in identicalSequenceRange util: Use primordial ArrayPrototypeIndexOf in identicalSequenceRange

Jun 28, 2023

@DaisyDogs07 DaisyDogs07 changed the title util: Use primordial ArrayPrototypeIndexOf in identicalSequenceRange util: Use primordials.ArrayPrototypeIndexOf in identicalSequenceRange

Jun 28, 2023

@DaisyDogs07 DaisyDogs07 changed the title util: Use primordials.ArrayPrototypeIndexOf in identicalSequenceRange util: Use primordials.ArrayPrototypeIndexOf instead of mutable method

Jun 28, 2023

@DaisyDogs07 @aduh95 

I believe you forgot to use the primordial `ArrayPrototypeIndexOf` in `identicalSequenceRange`
i dont know if this was intentional but im fixing it anyway :p

@aduh95 aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Jun 30, 2023

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023 
PR-URL: nodejs#48586
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023 
PR-URL: nodejs#48586
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request

Aug 14, 2023 
PR-URL: nodejs#48586
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Aug 15, 2023 
PR-URL: #48586
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

ruyadorno pushed a commit that referenced this pull request

Sep 12, 2023 
PR-URL: #48586
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

ruyadorno pushed a commit that referenced this pull request

Sep 13, 2023 
PR-URL: #48586
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

ruyadorno pushed a commit that referenced this pull request

Sep 17, 2023 
PR-URL: #48586
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>