Home Original page

Revert "test: remove test-crypto-keygen flaky designation" by lpinca · Pull Request #48652 · nodejs/node

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

test

Issues and PRs related to the tests.

labels

Jul 4, 2023

@lpinca

richardlau

StefanStojanovic

@lpinca lpinca added request-ci

Add this label to start a Jenkins CI on a PR.

fast-track

PRs that do not need to wait for 72 hours to land.

labels

Jul 4, 2023

KhafraDev

@lpinca lpinca added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Jul 5, 2023

@lpinca lpinca deleted the revert/893c000 branch

July 5, 2023 16:41

juanarbol pushed a commit that referenced this pull request

Jul 13, 2023 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023

ruyadorno pushed a commit that referenced this pull request

Sep 11, 2023 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

ruyadorno pushed a commit that referenced this pull request

Sep 13, 2023 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

ruyadorno pushed a commit that referenced this pull request

Sep 17, 2023 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

Sep 19, 2023

codebytere added a commit to electron/electron that referenced this pull request

Sep 19, 2023

codebytere added a commit to electron/electron that referenced this pull request

Sep 20, 2023

codebytere added a commit to electron/electron that referenced this pull request

Sep 20, 2023

codebytere added a commit to electron/electron that referenced this pull request

Sep 20, 2023

jkleinsc pushed a commit to electron/electron that referenced this pull request

Sep 20, 2023 
* chore: bump node in DEPS to v18.18.0

* child_process: harden against prototype pollution

nodejs/node#48726

* deps: upgrade to libuv 1.46.0

nodejs/node#49591

* module: reduce url invocations in esm/load.js

nodejs/node#48337

* Revert "test: remove test-crypto-keygen flaky designation"

nodejs/node#48652

* fix: FTBTFS in ada dep

ada-url/ada#464
ada-url/idna#31

* fix: force_colors snapshot line number

* chore: fixup patch indices

* chore: update filenames.json

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request

Dec 11, 2023 
* chore: bump node in DEPS to v18.18.0

* child_process: harden against prototype pollution

nodejs/node#48726

* deps: upgrade to libuv 1.46.0

nodejs/node#49591

* module: reduce url invocations in esm/load.js

nodejs/node#48337

* Revert "test: remove test-crypto-keygen flaky designation"

nodejs/node#48652

* fix: FTBTFS in ada dep

ada-url/ada#464
ada-url/idna#31

* fix: force_colors snapshot line number

* chore: fixup patch indices

* chore: update filenames.json

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>