Home Original page

src: remove OnScopeLeaveImpl's move assignment overload by CGQAQ · Pull Request #48732 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

Jul 11, 2023

RaisinTen

RaisinTen

@CGQAQ CGQAQ changed the title src: fix OnScopeLeaveImpl move assignment src: Remove OnScopeLeaveImpl's move assignment overload as it has not been used

Jul 12, 2023 
... as it's not valid implementation and also has not been used

@CGQAQ

@CGQAQ

@CGQAQ CGQAQ changed the title src: Remove OnScopeLeaveImpl's move assignment overload as it has not been used src: remove OnScopeLeaveImpl's move assignment overload

Jul 12, 2023

RaisinTen

@RaisinTen RaisinTen added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

labels

Jul 12, 2023

@CGQAQ CGQAQ deleted the src-fix-OnScopeLeaveImpl-moveassignment branch

July 17, 2023 00:27

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023 
... as it's not valid implementation and also has not been used

PR-URL: nodejs#48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023 
... as it's not valid implementation and also has not been used

PR-URL: nodejs#48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request

Aug 14, 2023 
... as it's not valid implementation and also has not been used

PR-URL: nodejs#48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Aug 15, 2023 
... as it's not valid implementation and also has not been used

PR-URL: #48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Nov 27, 2023 
... as it's not valid implementation and also has not been used

PR-URL: #48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024 
... as it's not valid implementation and also has not been used

PR-URL: nodejs/node#48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024 
... as it's not valid implementation and also has not been used

PR-URL: nodejs/node#48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>