[v18.x backport] url: ensure getter access do not mutate observable symbols by aduh95 · Pull Request #48891

[v18.x backport] url: ensure getter access do not mutate observable symbols by aduh95 · Pull Request #48891 · nodejs/node

nodejs-github-bot added needs-ci

PRs that need a full CI run.

v18.x

Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

whatwg-url

Issues and PRs related to the WHATWG URL implementation.

labels

Jul 23, 2023

aduh95 changed the title ~~url: ensure getter access do not mutate observable symbols~~ [v18.x] url: ensure getter access do not mutate observable symbols

Jul 23, 2023

aduh95 linked an issue

Jul 23, 2023

that may be closed by this pull request

The test's assumptions about RSS are no longer valid, at least with
Fedora 38.

Closes: nodejs#48490
PR-URL: nodejs#48811
Fixes: nodejs#48490
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

nodejs-github-bot pushed a commit that referenced this pull request

Jul 24, 2023

PR-URL: #48897
Refs: #48891
Refs: #48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

aduh95 marked this pull request as ready for review

July 24, 2023 09:25

aduh95 changed the title ~~[v18.x] url: ensure getter access do not mutate observable symbols~~ [v18.x backport] url: ensure getter access do not mutate observable symbols

Jul 24, 2023

anonrig added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jul 26, 2023

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Jul 27, 2023

pluris pushed a commit to pluris/node that referenced this pull request

Aug 6, 2023

pluris pushed a commit to pluris/node that referenced this pull request

Aug 7, 2023

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023

UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request

Aug 14, 2023

RafaelGSS pushed a commit that referenced this pull request

Aug 15, 2023

PR-URL: #48897
Refs: #48891
Refs: #48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

ruyadorno pushed a commit that referenced this pull request

Aug 16, 2023

PR-URL: #48897
Backport-PR-URL: #48891
Refs: #48891
Refs: #48886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

aduh95 deleted the url-observable-symbols-v18.x branch

August 16, 2023 22:21