Home Original page

src: use ARES_SUCCESS instead of 0 by pluris · Pull Request #49048 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

cares

Issues and PRs related to the c-ares dependency or the cares_wrap binding.

needs-ci

PRs that need a full CI run.

labels

Aug 7, 2023

ShogunPanda

mcollina

deokjinkim

@deokjinkim deokjinkim added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 11, 2023

This was referenced

Aug 14, 2023

deokjinkim

This was referenced

Aug 21, 2023

@pluris pluris deleted the fix/return_value_ares branch

August 30, 2023 16:12

UlisesGascon pushed a commit that referenced this pull request

Sep 10, 2023 
PR-URL: #49048
Refs: #48834
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

targos pushed a commit that referenced this pull request

Nov 27, 2023 
PR-URL: #49048
Refs: #48834
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024 
PR-URL: nodejs/node#49048
Refs: nodejs/node#48834
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024 
PR-URL: nodejs/node#49048
Refs: nodejs/node#48834
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>