bootstrap: do not generate code cache in an unfinalized isolate by joyeecheung · Pull Request #49108

bootstrap: do not generate code cache in an unfinalized isolate by joyeecheung · Pull Request #49108 · nodejs/node

marked this pull request as ready for review

August 11, 2023 14:31

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

Aug 11, 2023

This was referenced

Aug 13, 2023

V8 now no longer supports serializing code cache in an isolate
with unfinalized read-only space. So guard the code cache regeneration
with the `is_building_snapshot()` flag. When the isolate is created
for snapshot generation, the code cache is going to be serialized
separately anyway, so there is no need to do it in the builtin loader.

This was referenced

Aug 18, 2023

UlisesGascon pushed a commit that referenced this pull request

Sep 10, 2023

V8 now no longer supports serializing code cache in an isolate
with unfinalized read-only space. So guard the code cache regeneration
with the `is_building_snapshot()` flag. When the isolate is created
for snapshot generation, the code cache is going to be serialized
separately anyway, so there is no need to do it in the builtin loader.

PR-URL: #49108
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>