Home Original page

test_runner: expose spec reporter as newable function by atlowChemi · Pull Request #49184 · nodejs/node

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

test

Issues and PRs related to the tests.

labels

Aug 15, 2023

@atlowChemi atlowChemi added test_runner

Issues and PRs related to the test runner subsystem.

and removed test

Issues and PRs related to the tests.

labels

Aug 15, 2023

benjamingr

@atlowChemi

@MoLow MoLow changed the title test_runner: expose test_runner as newable function test_runner: expose spec reporter as newable function

Aug 16, 2023

@MoLow MoLow added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Aug 16, 2023

UlisesGascon pushed a commit that referenced this pull request

Sep 10, 2023 
Fixes: #48112
Ref: #48208
PR-URL: #49184
Refs: #48208
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

targos pushed a commit that referenced this pull request

Nov 27, 2023 
Fixes: #48112
Ref: #48208
PR-URL: #49184
Refs: #48208
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

atlowChemi added a commit to atlowChemi/node that referenced this pull request

Apr 7, 2024

atlowChemi added a commit to atlowChemi/node that referenced this pull request

Apr 14, 2024 
This commit exposes the lcov reporter as a newable function, so that it
can be used in the same way as the other reporters.
This will allow passing in the options to the reporter as well.
This breaks the current behavior of the lcov reporter, which exposes an
instance of the reporter.

Fixes: nodejs#52385
Ref: nodejs#49184

nodejs-github-bot pushed a commit that referenced this pull request

Apr 15, 2024 
This commit exposes the lcov reporter as a newable function, so that it
can be used in the same way as the other reporters.
This will allow passing in the options to the reporter as well.
This breaks the current behavior of the lcov reporter, which exposes an
instance of the reporter.

Fixes: #52385
Ref: #49184
PR-URL: #52403
Refs: #49184
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024

aduh95 pushed a commit that referenced this pull request

Apr 30, 2024 
This commit exposes the lcov reporter as a newable function, so that it
can be used in the same way as the other reporters.
This will allow passing in the options to the reporter as well.
This breaks the current behavior of the lcov reporter, which exposes an
instance of the reporter.

Fixes: #52385
Ref: #49184
PR-URL: #52403
Refs: #49184
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>