[v20.x backport] test_runner: fix global before not called when no global test exists by rluvaton · Pull Request #49219 · nodejs/node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@rluvaton

Copy link

Member

@rluvaton rluvaton commented

Aug 17, 2023

edited

Loading

Backports: #48877
Backport-PR-URL: #49219

Question: shouldn't backport PR contain conflict fixes? because I did not have any...

bricss reacted with eyes emoji
PR-URL: nodejs#48877
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

@nodejs-github-bot

Copy link

Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

v20.x

Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

labels

Aug 17, 2023

@rluvaton rluvaton added the request-ci

Add this label to start a Jenkins CI on a PR.

label

Aug 17, 2023

@github-actions github-actions bot removed the request-ci

Add this label to start a Jenkins CI on a PR.

label

Aug 17, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

v20.x

Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rluvaton @nodejs-github-bot