[v20.x backport] backport multiple test runner related prs by rluvaton · Pull Request #49225 · nodejs/node

[v20.x backport] backport multiple test runner related prs by rluvaton · Pull Request #49225 · nodejs/node

PRs that need a full CI run.

Issues and PRs related to the tests.

Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

labels

rluvaton marked this pull request as ready for review

August 18, 2023 10:05

This was referenced

Aug 18, 2023

This was referenced

Aug 21, 2023

PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

PR-URL: nodejs#48877
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

fix nodejs#48475

PR-URL: nodejs#48915
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

PR-URL: nodejs#48925
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

PR-URL: nodejs#48913
Fixes: nodejs#48867
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

This commit adds each test's line and column number to the reporter
output. This will aid in debugging test suite failures when error
stacks are not helpful, test suites are large, or tests have the
same name. This data is also exposed on the spec reporter.

This commit also replaces the filename that was previously being
reported, with the filename where the test actually exists. These
are normally correct, but could be wrong if tests were run from
a file other than the user's entrypoint.

PR-URL: nodejs#48975
Fixes: nodejs#48457
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

UlisesGascon pushed a commit that referenced this pull request

PR-URL: #48787
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

UlisesGascon pushed a commit that referenced this pull request

PR-URL: #48877
Backport-PR-URL: #49225
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

UlisesGascon pushed a commit that referenced this pull request

fix #48475

PR-URL: #48915
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

UlisesGascon pushed a commit that referenced this pull request

PR-URL: #48925
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

UlisesGascon pushed a commit that referenced this pull request

PR-URL: #48913
Backport-PR-URL: #49225
Fixes: #48867
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

UlisesGascon pushed a commit that referenced this pull request

no longer needed after #48915 fix

PR-URL: #48989
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

UlisesGascon pushed a commit that referenced this pull request

This commit adds each test's line and column number to the reporter
output. This will aid in debugging test suite failures when error
stacks are not helpful, test suites are large, or tests have the
same name. This data is also exposed on the spec reporter.

This commit also replaces the filename that was previously being
reported, with the filename where the test actually exists. These
are normally correct, but could be wrong if tests were run from
a file other than the user's entrypoint.

PR-URL: #48975
Backport-PR-URL: #49225
Fixes: #48457
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

UlisesGascon pushed a commit that referenced this pull request

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Backport-PR-URL: #49225
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

targos pushed a commit that referenced this pull request

PR-URL: #48787
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

targos pushed a commit that referenced this pull request

PR-URL: #48913
Backport-PR-URL: #49225
Fixes: #48867
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

targos pushed a commit that referenced this pull request

no longer needed after #48915 fix

PR-URL: #48989
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

sercher added a commit to sercher/graaljs that referenced this pull request

sercher added a commit to sercher/graaljs that referenced this pull request

sercher added a commit to sercher/graaljs that referenced this pull request

no longer needed after #48915 fix

PR-URL: nodejs/node#48989
Backport-PR-URL: nodejs/node#49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

sercher added a commit to sercher/graaljs that referenced this pull request

sercher added a commit to sercher/graaljs that referenced this pull request

sercher added a commit to sercher/graaljs that referenced this pull request

no longer needed after #48915 fix

PR-URL: nodejs/node#48989
Backport-PR-URL: nodejs/node#49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>