bootstrap: only use the isolate snapshot when compiling code cache by joyeecheung · Pull Request #49288

bootstrap: only use the isolate snapshot when compiling code cache by joyeecheung · Pull Request #49288 · nodejs/node

We do not actually need to deserialize the context and the whole
environment to compile the code cache, since code cache are not
context-dependent anyway, deserializing just the isolate snapshot is
enough.

marked this pull request as ready for review

August 22, 2023 17:28

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

Aug 22, 2023

This was referenced

Aug 24, 2023

This was referenced

Sep 3, 2023

joyeecheung added a commit that referenced this pull request

Sep 4, 2023

We do not actually need to deserialize the context and the whole
environment to compile the code cache, since code cache are not
context-dependent anyway, deserializing just the isolate snapshot is
enough.

PR-URL: #49288
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

This was referenced

Sep 5, 2023

ruyadorno pushed a commit that referenced this pull request

Sep 28, 2023

We do not actually need to deserialize the context and the whole
environment to compile the code cache, since code cache are not
context-dependent anyway, deserializing just the isolate snapshot is
enough.

PR-URL: #49288
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

This was referenced

Sep 28, 2023

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023

We do not actually need to deserialize the context and the whole
environment to compile the code cache, since code cache are not
context-dependent anyway, deserializing just the isolate snapshot is
enough.

PR-URL: nodejs#49288
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>