Home Original page

[v18.x backport] stream: fix deadlock when pipeing to full sink by kanongil · Pull Request #49323 · nodejs/node

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

v18.x

Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

labels

Aug 25, 2023

@ronag @kanongil 

When piping a paused Readable to a full Writable we didn't
register a drain listener which cause the src to never
resume.

Refs: nodejs#48666
PR-URL: nodejs#48691
Backport-PR-URL: nodejs#49323
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

ruyadorno

ruyadorno pushed a commit that referenced this pull request

Sep 8, 2023 
When piping a paused Readable to a full Writable we didn't
register a drain listener which cause the src to never
resume.

Refs: #48666
PR-URL: #48691
Backport-PR-URL: #49323
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

ruyadorno pushed a commit that referenced this pull request

Sep 13, 2023 
When piping a paused Readable to a full Writable we didn't
register a drain listener which cause the src to never
resume.

Refs: #48666
PR-URL: #48691
Backport-PR-URL: #49323
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>