Home Original page

src: remove unused PromiseWrap-related code by joyeecheung · Pull Request #49335 · nodejs/node

@joyeecheung 

PromiseWrap has been removed in
nodejs#39135 and we do not have any
internal object setting the internal field at 0 as a promise
(we always set the first field as an aligned pointer to
the embedder ID). As result GetAssignedPromiseWrapAsyncId()
always just returns AsyncWrap::kInvalidAsyncId and turn
the removed block into noops. So the block just can be removed.

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

Aug 26, 2023

RaisinTen

This was referenced

Aug 29, 2023

@Flarna Flarna added async_hooks

Issues and PRs related to the async hooks subsystem.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Sep 1, 2023

This was referenced

Sep 2, 2023

UlisesGascon pushed a commit that referenced this pull request

Sep 10, 2023 
PromiseWrap has been removed in
#39135 and we do not have any
internal object setting the internal field at 0 as a promise
(we always set the first field as an aligned pointer to
the embedder ID). As result GetAssignedPromiseWrapAsyncId()
always just returns AsyncWrap::kInvalidAsyncId and turn
the removed block into noops. So the block just can be removed.

PR-URL: #49335
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023 
PromiseWrap has been removed in
nodejs#39135 and we do not have any
internal object setting the internal field at 0 as a promise
(we always set the first field as an aligned pointer to
the embedder ID). As result GetAssignedPromiseWrapAsyncId()
always just returns AsyncWrap::kInvalidAsyncId and turn
the removed block into noops. So the block just can be removed.

PR-URL: nodejs#49335
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>