Home Original page

src: modify code for empty string by pluris · Pull Request #49336 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

whatwg-url

Issues and PRs related to the WHATWG URL implementation.

labels

Aug 26, 2023

bnoordhuis

@pluris pluris changed the title src: change String::NewFromUtf8 to FIXED_ONE_BYTE_STRING src: modify code for empty string

Aug 27, 2023

bnoordhuis

RaisinTen

@aduh95 aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Aug 29, 2023

debadree25

debadree25 pushed a commit that referenced this pull request

Sep 1, 2023 
PR-URL: #49336
Refs: #49097
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>

UlisesGascon pushed a commit that referenced this pull request

Sep 10, 2023 
PR-URL: #49336
Refs: #49097
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>

@pluris pluris deleted the fix/apply_comment_49097 branch

September 11, 2023 00:46

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023 
PR-URL: nodejs#49336
Refs: nodejs#49097
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>