Home Original page

test: simplify test-crypto-dh-group-setters by tniessen · Pull Request #49404 · nodejs/node

@tniessen 

I can't tell why the test was written that way in the first place, but
it seems sufficient to check that setPrivateKey and setPublicKey are
both undefined.

Refs: nodejs/node-v0.x-archive#2638
Refs: nodejs#11253

@tniessen added crypto

Issues and PRs related to the crypto subsystem.

test

Issues and PRs related to the tests.

labels

Aug 29, 2023

@panva panva added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Aug 30, 2023

This was referenced

Sep 1, 2023

UlisesGascon pushed a commit that referenced this pull request

Sep 10, 2023 
I can't tell why the test was written that way in the first place, but
it seems sufficient to check that setPrivateKey and setPublicKey are
both undefined.

Refs: nodejs/node-v0.x-archive#2638
Refs: #11253
PR-URL: #49404
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023 
I can't tell why the test was written that way in the first place, but
it seems sufficient to check that setPrivateKey and setPublicKey are
both undefined.

Refs: nodejs/node-v0.x-archive#2638
Refs: nodejs#11253
PR-URL: nodejs#49404
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>