doc: Fix missing imports in script by OshriAsulin · Pull Request #49489 · nodejs/node
added
doc
labels
Sep 4, 2023This was referenced
Sep 4, 2023The script was missing necessary imports for the `run` function and the `path` module, causing it to fail. This commit adds the missing imports and resolves the issue. - Import `run` from the appropriate module. - Import `path` to resolve file paths. The script should now run without errors.
This commit enhances the script by addressing missing imports for the 'run' function and the 'path' module, which previously resulted in script failure. The following improvements have been made: Imported 'run' from the appropriate module via require to ensure correct functionality. Imported 'path' via require to facilitate proper file path resolution. Imported 'process' via require to include this essential module. These changes resolve the issue of missing dependencies execution.
In this commit, I've refactored the import statements and destructuring assignments in the codebase to enhance code organization and maintainability. The primary changes are as follows:
1. Replaced the import statement:
- From: `import { tap, run } from 'node:test/reporters';`
- To:
- `import { run } from 'node:test';`
- `import { tap } from 'node:test/reporters';`
2. Reorganized destructuring assignments:
- From:
```
const { tap, run } = require('node:test/reporters');
const process = require('process');
```
- To:
```
const { run } = require('node:test');
const { tap } = require('node:test/reporters');
```
ruyadorno pushed a commit that referenced this pull request
Sep 28, 2023The script was missing necessary imports for the `run` function and the `path` module, causing it to fail. This commit adds the missing imports and resolves the issue. - Import `run` from the appropriate module. - Import `path` to resolve file paths. The script should now run without errors. PR-URL: #49489 Fixes: #49488 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced
Sep 28, 2023alexfernandez pushed a commit to alexfernandez/node that referenced this pull request
Nov 1, 2023The script was missing necessary imports for the `run` function and the `path` module, causing it to fail. This commit adds the missing imports and resolves the issue. - Import `run` from the appropriate module. - Import `path` to resolve file paths. The script should now run without errors. PR-URL: nodejs#49489 Fixes: nodejs#49488 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters