Home Original page

esm: fix loading of (recursive) CJS modules from ESM by aduh95 · Pull Request #49500 · nodejs/node

@aduh95

@nodejs-github-bot added esm

Issues and PRs related to the ECMAScript Modules implementation.

needs-ci

PRs that need a full CI run.

labels

Sep 5, 2023

nicolo-ribaudo

GeoffreyBooth

Qard

Qard approved these changes Sep 6, 2023

benjamingr

@aduh95 aduh95 added fast-track

PRs that do not need to wait for 72 hours to land.

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Sep 6, 2023

JakobJingleheimer

@aduh95 aduh95 deleted the fix-cjs-recursive branch

September 6, 2023 10:12

This was referenced

Sep 7, 2023

@azu azu mentioned this pull request

Sep 7, 2023

RafaelGSS pushed a commit that referenced this pull request

Sep 7, 2023 
PR-URL: #49500
Fixes: #49497
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>

RafaelGSS added a commit that referenced this pull request

Sep 7, 2023 
Notable changes:

esm:
  * fix loading of CJS modules from ESM (Antoine du Hamel) #49500

PR-URL: TBD

RafaelGSS added a commit that referenced this pull request

Sep 7, 2023 
Notable changes:

esm:
  * fix loading of CJS modules from ESM (Antoine du Hamel) #49500

PR-URL: #49528

ruyadorno pushed a commit that referenced this pull request

Sep 8, 2023 
Notable changes:

esm:
  * fix loading of CJS modules from ESM (Antoine du Hamel) #49500

PR-URL: #49528

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023 
PR-URL: nodejs#49500
Fixes: nodejs#49497
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023