util/mime: pass invalidSubtypeIndex instead of trimmedSubtype to error by gaurishhs · Pull Request #49711 · nodejs/node
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 35.1k
Closed
util/mime: pass invalidSubtypeIndex instead of trimmedSubtype to error#49711
gaurishhs wants to merge 1 commit intonodejs:mainfrom
gaurishhs:gaurishhs/fix-mime
util/mime: pass invalidSubtypeIndex instead of trimmedSubtype to error#49711
gaurishhs wants to merge 1 commit intonodejs:mainfrom
gaurishhs:gaurishhs/fix-mime
Conversation
Copy link
Contributor
gaurishhs
commented
Sep 19, 2023
gaurishhs
commented
The error ERR_INVALID_MIME_SYNTAX expects the invalid index which wasn't being passed.
gaurishhs
changed the title
fix: pass invalidSubtypeIndex instead of trimmedSubtype to error
mime: pass invalidSubtypeIndex instead of trimmedSubtype to error
gaurishhs
changed the title
mime: pass invalidSubtypeIndex instead of trimmedSubtype to error
util/mime: pass invalidSubtypeIndex instead of trimmedSubtype to error
jasnell approved these changes Oct 28, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced
Oct 29, 2023
Copy link
Contributor Author
gaurishhs
commented
Nov 4, 2023
gaurishhs commented
Nov 4, 2023hi, any updates?
Copy link
Collaborator
nodejs-github-bot
commented
Nov 11, 2023
nodejs-github-bot commented
Nov 11, 2023This was referenced
Nov 12, 2023
deokjinkim
mentioned this pull request
deokjinkim approved these changes Dec 23, 2023
Copy link
Contributor
deokjinkim
commented
Dec 23, 2023
deokjinkim commented
Dec 23, 2023@gaurishhs Could you modify commit title according to guide(https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines)?
Commit title should be started with submodule name such as util.
gaurishhs
closed this
gaurishhs
mentioned this pull request
Copy link
Contributor Author
gaurishhs
commented
Dec 23, 2023
gaurishhs commented
Dec 23, 2023@deokjinkim @jasnell I was having conflicts on my local git while rebasing. I have opened a new PR to make things good. Please look into #51264
I'm sorry for the mess i created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment