Home Original page

fs: improve error performance for `rmdirSync` by CanadaHonk · Pull Request #49846 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

fs

Issues and PRs related to the fs subsystem / file system.

needs-ci

PRs that need a full CI run.

labels

Sep 25, 2023

anonrig

anonrig

@CanadaHonk CanadaHonk changed the title fs: improve performance for fs.rmdirSync fs: improve error performance for fs.rmdirSync

Sep 25, 2023

@anonrig anonrig added performance

Issues and PRs related to the performance of Node.js.

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

needs-benchmark-ci

PR that need a benchmark CI run.

labels

Sep 25, 2023

@CanadaHonk CanadaHonk changed the title fs: improve error performance for fs.rmdirSync fs: improve error performance for rmdirSync

Sep 25, 2023

@CanadaHonk

H4ad

H4ad approved these changes Nov 26, 2023

@H4ad H4ad added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Nov 26, 2023

lucshi pushed a commit to lucshi/node that referenced this pull request

Nov 27, 2023 
PR-URL: nodejs#49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

RafaelGSS pushed a commit that referenced this pull request

Nov 27, 2023 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

RafaelGSS pushed a commit that referenced this pull request

Nov 29, 2023 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

RafaelGSS pushed a commit that referenced this pull request

Nov 30, 2023 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

UlisesGascon pushed a commit that referenced this pull request

Dec 13, 2023 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

UlisesGascon pushed a commit that referenced this pull request

Dec 15, 2023 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

UlisesGascon pushed a commit that referenced this pull request

Dec 19, 2023 
PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>