test_runner: replace spurious if with else by cjihrig · Pull Request #49943

test_runner: replace spurious if with else by cjihrig · Pull Request #49943 · nodejs/node

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs#48915

added needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

labels

Sep 28, 2023

aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Sep 29, 2023

aduh95 added fast-track

PRs that do not need to wait for 72 hours to land.

and removed commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Sep 29, 2023

aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Sep 29, 2023

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs#48915
PR-URL: nodejs#49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>

targos pushed a commit that referenced this pull request

Nov 11, 2023

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: #48915
PR-URL: #49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>

targos pushed a commit that referenced this pull request

Nov 27, 2023

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: #48915
PR-URL: #49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>

debadree25 pushed a commit to debadree25/node that referenced this pull request

Apr 15, 2024

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs#48915
PR-URL: nodejs#49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs/node#48915
PR-URL: nodejs/node#49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs/node#48915
PR-URL: nodejs/node#49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>