Home Original page

stream: bump default highWaterMark by RafaelGSS · Pull Request #50120 · nodejs/node

@RafaelGSS added stream

Issues and PRs related to the stream subsystem.

semver-major

PRs that contain breaking changes and should be released in the next major version.

labels

Oct 10, 2023

rubiesonthesky

mcollina

mcollina

benjamingr

This was referenced

Oct 30, 2023

@ronag @RafaelGSS 

This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has
doubled many times since I think it is appropriate to slightly bump
the default limit.

@RafaelGSS

@RafaelGSS

@RafaelGSS

lpinca added a commit to websockets/ws that referenced this pull request

Dec 26, 2023

@lpinca

@ronag ronag mentioned this pull request

Mar 10, 2024

ronag added a commit to nxtedition/node that referenced this pull request

Mar 10, 2024 
This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has
doubled many times since I think it is appropriate to slightly bump
the default limit.

Refs: nodejs#46608
Refs: nodejs#50120

ronag added a commit to nxtedition/node that referenced this pull request

Mar 10, 2024 
This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has
doubled many times since I think it is appropriate to slightly bump
the default limit.

PR-URL: nodejs#52037
Refs: nodejs#46608
Refs: nodejs#50120

ronag added a commit to nxtedition/node that referenced this pull request

Mar 10, 2024 
This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has
doubled many times since I think it is appropriate to slightly bump
the default limit.

PR-URL: nodejs#52037
Refs: nodejs#46608
Refs: nodejs#50120

ronag added a commit to nxtedition/node that referenced this pull request

Mar 11, 2024 
This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has
doubled many times since I think it is appropriate to slightly bump
the default limit.

PR-URL: nodejs#52037
Refs: nodejs#46608
Refs: nodejs#50120

ronag added a commit to nxtedition/node that referenced this pull request

Mar 11, 2024 
This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has
doubled many times since I think it is appropriate to slightly bump
the default limit.

PR-URL: nodejs#52037
Refs: nodejs#46608
Refs: nodejs#50120

ronag added a commit to nxtedition/node that referenced this pull request

Mar 13, 2024 
This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has
doubled many times since I think it is appropriate to slightly bump
the default limit.

PR-URL: nodejs#52037
Refs: nodejs#46608
Refs: nodejs#50120

ronag added a commit to nxtedition/node that referenced this pull request

Mar 13, 2024 
This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has
doubled many times since I think it is appropriate to slightly bump
the default limit.

PR-URL: nodejs#52037
Refs: nodejs#46608
Refs: nodejs#50120

nodejs-github-bot pushed a commit that referenced this pull request

Mar 13, 2024 
This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has
doubled many times since I think it is appropriate to slightly bump
the default limit.

PR-URL: #52037
Refs: #46608
Refs: #50120
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request

Mar 26, 2024 
This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has
doubled many times since I think it is appropriate to slightly bump
the default limit.

PR-URL: nodejs#52037
Refs: nodejs#46608
Refs: nodejs#50120
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

jcbhmr pushed a commit to jcbhmr/node that referenced this pull request

May 15, 2024 
This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has
doubled many times since I think it is appropriate to slightly bump
the default limit.

PR-URL: nodejs#52037
Refs: nodejs#46608
Refs: nodejs#50120
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>